Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cache for SharedCredentialFile #3174

Closed

Conversation

outcoldman
Copy link

Implementation to support cache for when MFA is used for shared credential files. See aws/aws-sdk#529
Depends on boto/botocore#1399

@outcoldman outcoldman force-pushed the aws_mfa_for_shared_credential_file branch from d13454e to 6318517 Compare March 3, 2018 01:16
@codecov-io
Copy link

codecov-io commented Mar 3, 2018

Codecov Report

Merging #3174 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    aws/aws-cli#3174      +/-   ##
===========================================
- Coverage    97.11%   97.11%   -0.01%     
===========================================
  Files          407      407              
  Lines        33515    33536      +21     
===========================================
+ Hits         32548    32568      +20     
- Misses         967      968       +1
Impacted Files Coverage Δ
awscli/customizations/sessiontokenservice.py 100% <100%> (ø)
...ts/unit/customizations/test_sessiontokenservice.py 100% <100%> (ø)
awscli/handlers.py 100% <100%> (ø) ⬆️
awscli/clidocs.py 98.37% <0%> (-0.21%) ⬇️
...nit/customizations/cloudformation/test_deployer.py 100% <0%> (ø) ⬆️
awscli/customizations/cloudformation/deployer.py 96.73% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520d2f9...6318517. Read the comment docs.

@ahl
Copy link

ahl commented Apr 1, 2018

This would be extremely useful; I hope it gets merged.

@Kiddinglife
Copy link

need this

@zhe-zhao
Copy link

Have to say that working with MFA in cli is rather unpleasant. You'll have to write some script to:

  1. Get MFA device arn
  2. Get session with MFA arn and MFA code
  3. Store temp access key & token somewhere

It would be really nice if we can get a built-in solution e.g. a mfa_serial parameter in profile config etc.

@webbrandon
Copy link

Kinda wish someone would move or address this PR after 2 years of being open. This would be useful and make it so we don't have get dev's setup with automation script to make development more productive.

@benjaminW78
Copy link

THIS MR would so well solve my problem. i want more security so i activated MFA but now it's becoming hell to use AWS CLI with mfa. but their is stuff that i can only do by AWS CLI for ECS ... so i'm stuck at trying to figure out how to have a seamless experience.

@kdaily kdaily added feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. labels Sep 28, 2021
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
@whereismypen
Copy link

How can we (cloud users) be expected to improve our security stance when the cloud provider doesn't provide us with the tools. Please review and commit this.

@stealthycoin
Copy link
Contributor

stealthycoin commented Apr 13, 2022

Updated the issue with guidance from our new contributing process. Marking this PR as a DRAFT as we would not accept a PR that effects security and credential loading without a clear design doc that we can review and approve in advance.
The issue itself is marked as blocked, which means it is waiting on a design spec to be written. Once someone posts a design and the design is iterated on with team member's and we approve it, it can be advanced to the contribution-ready stage.

@stealthycoin stealthycoin marked this pull request as draft April 13, 2022 20:52
@justindho justindho added community and removed needs-review This issue or pull request needs review from a core team member. labels May 20, 2022
@tim-finnigan
Copy link
Contributor

Thank you for creating this PR and for your patience here. Regarding this point mentioned earlier:

...we would not accept a PR that effects security and credential loading without a clear design doc that we can review and approve in advance.

This design doc will need to be considered at a cross-SDK level, and so we have transferred the corresponding issue (aws/aws-sdk#529) to our cross-SDK repository for further tracking. Please 👍 the issue if also interested in this feature and comment there if you have any additional info to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mfa_serial support for user profiles