-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cache for SharedCredentialFile #3174
Support cache for SharedCredentialFile #3174
Conversation
a6b7885
to
d13454e
Compare
d13454e
to
6318517
Compare
Codecov Report
@@ Coverage Diff @@
## develop aws/aws-cli#3174 +/- ##
===========================================
- Coverage 97.11% 97.11% -0.01%
===========================================
Files 407 407
Lines 33515 33536 +21
===========================================
+ Hits 32548 32568 +20
- Misses 967 968 +1
Continue to review full report at Codecov.
|
This would be extremely useful; I hope it gets merged. |
need this |
Have to say that working with MFA in cli is rather unpleasant. You'll have to write some script to:
It would be really nice if we can get a built-in solution e.g. a mfa_serial parameter in profile config etc. |
Kinda wish someone would move or address this PR after 2 years of being open. This would be useful and make it so we don't have get dev's setup with automation script to make development more productive. |
THIS MR would so well solve my problem. i want more security so i activated MFA but now it's becoming hell to use AWS CLI with mfa. but their is stuff that i can only do by AWS CLI for ECS ... so i'm stuck at trying to figure out how to have a seamless experience. |
How can we (cloud users) be expected to improve our security stance when the cloud provider doesn't provide us with the tools. Please review and commit this. |
Updated the issue with guidance from our new contributing process. Marking this PR as a DRAFT as we would not accept a PR that effects security and credential loading without a clear design doc that we can review and approve in advance. |
Thank you for creating this PR and for your patience here. Regarding this point mentioned earlier:
This design doc will need to be considered at a cross-SDK level, and so we have transferred the corresponding issue (aws/aws-sdk#529) to our cross-SDK repository for further tracking. Please 👍 the issue if also interested in this feature and comment there if you have any additional info to share. |
Implementation to support cache for when MFA is used for shared credential files. See aws/aws-sdk#529
Depends on boto/botocore#1399