-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependency versions to fix audit scanning #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run integration tests on this change?
@@ -6,7 +6,7 @@ | |||
"scripts": { | |||
"clean": "npx shx rm -rf dist tsconfig.tsbuildinfo bundle.zip .rush .nyc_output *.log", | |||
"lint": "npx eslint . --ext '.ts'", | |||
"build": "npx tsc -b && npx shx cp -R 'src/config' 'dist/'", | |||
"build": "npx tsc -p tsconfig.json && npx shx cp -R 'src/config' 'dist/'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note about why this change exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an attempt to make command
package pass the build. The rest of the packages use npx tsc -p tsconfig.json
for build, so I kept this change in the PR.
@@ -114,6 +116,5 @@ export interface DeploymentPolicy { | |||
}; | |||
} | |||
|
|||
export type AbortConfigFailureType = 'FAILED' | 'REJECTED' | 'TIMED_OUT' | 'ALL'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I reading this right that we're now getting this type from their library instead of defining it ourselves? Does the same not apply to the other exported types below? If so, can you open an issue to update them to use the library values instead of defining them in our code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the newer version of the dependent AWS SDK package updated their typing from a general string
to more strict enum
, which results in this incompatibility. And you are right, this can apply to other types defined in the code base. I have created #211 to track this
Integration tests are passing |
Description
This PR upgrades packages version to address security scanning issues from
rush-pnpm audit
. It fixes all the issues but one:The package
[email protected]
is the latest version of package and has not been upgraded since. In my opinion, it's not a security threat because of the way (and the frequency) we use this package in our code base.Packages with major version upgrade:
Version upgrades are done via running
rush upgrade-interactive --make-consistent
, when a major version is available, rush will present only major version upgrade option for the package, investigation has been done to make sure there is no breaking change introduced.nodemon
:2.0.20
->3.1.0
luxon
:2.3.0
->3.4.4
busboy
:0.3.1
->1.6.0
command
package tocommand-and-control
package. There is no usage of this package in command-and-control package code. (see code search link)@types/busboy
:0.2.3
->1.5.4
Type of change
Submission Checklist
Additional Notes: