Skip to content

Commit

Permalink
test: stop .NET testing goals until Dafny fixes land
Browse files Browse the repository at this point in the history
Crypto Tools would like to prepare for our next release,
but it seems we have stumbled into a few Dafny bugs.

The Dafny .NET compiler is struggling with the Storage changes in

Additionally,
the Smithy-Diff workflow has generated far too much noise.
Crypto Tools use GitHub notifications to track customer cut
or updated GitHub issues.

Tagging a contributor for every commit pushed
generates far too much noise.

See #717
as evidence that '.github/workflows/block_main.yml' fails
if this commit targets main.
  • Loading branch information
texastony committed Sep 14, 2024
1 parent 36ab560 commit e2d928a
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 45 deletions.
17 changes: 17 additions & 0 deletions .github/workflows/block_main.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# This workflow ensures rc-1.7.0 does not go to main until .NET testing is restored
name: rc-1.7.0-no-main

on:
pull_request:
branches:
- main
jobs:
forbid:
runs-on: ubuntu-latest
steps:
- name: fail
run: exit 1
# When we revert this, we MUST revert/restore:
# .github/workflows/library_net_tests.yml#L27-L30
# .github/workflows/library_interop_tests.yml#L28-31
# .github/workflows/library_interop_tests.yml#L134-139
13 changes: 10 additions & 3 deletions .github/workflows/library_interop_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ jobs:
ubuntu-latest,
macos-12,
]
language: [java, net]
# language: [java, net]
# Cutting .NET tests for rc-1.7.0
# We MUST restore these before going GA
language: [java]
# https://taskei.amazon.dev/tasks/CrypTool-5284
dotnet-version: ["6.0.x"]
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -128,8 +131,12 @@ jobs:
ubuntu-latest,
macos-12,
]
encrypting_language: [java, net]
decrypting_language: [java, net]
# Cutting .NET tests for rc-1.7.0
# We MUST restore these before going GA
# encrypting_language: [java, net]
# decrypting_language: [java, net]
encrypting_language: [java]
decrypting_language: [java]
dotnet-version: ["6.0.x"]
runs-on: ${{ matrix.os }}
permissions:
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/library_net_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,15 @@ jobs:
strategy:
fail-fast: false
matrix:
library:
[
library: [
StandardLibrary,
AwsCryptographyPrimitives,
ComAmazonawsKms,
ComAmazonawsDynamodb,
AwsCryptographicMaterialProviders,
TestVectorsAwsCryptographicMaterialProviders,
# Cutting .NET tests for rc-1.7.0
# We MUST restore these before going GA
# AwsCryptographicMaterialProviders,
# TestVectorsAwsCryptographicMaterialProviders,
]
dotnet-version: ["6.0.x"]
os: [windows-latest, ubuntu-latest, macos-12]
Expand Down
38 changes: 0 additions & 38 deletions .github/workflows/smithy-diff.yml

This file was deleted.

0 comments on commit e2d928a

Please sign in to comment.