chore(GHA): add semantic release manual gha #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/sem_ver.yml
Outdated
Comment on lines
49
to
50
| # Test to see if we can setup semantic release | ||
| - name: Run Semantic Release in dry run mode |
There was a problem hiding this comment.
Are we just setting it up? Or also running dry run?
There was a problem hiding this comment.
oops forgot to change the name of the step; fixed now!
| workflow_dispatch: | ||
| inputs: | ||
| dry-run: | ||
| description: "Are you releasing a new version? (Y/n)" |
There was a problem hiding this comment.
I think the convention for CLIs is that a capital letter suggests it's a default argument. Should Y be lowercase y here?
.github/workflows/sem_ver.yml
Outdated
| @@ -0,0 +1,55 @@ | |||
| # This workflow runs semantic release in dry run mode | |||
There was a problem hiding this comment.
Is this comment still accurate?
lucasmcdonald3
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.