Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use shared SmithyDafnyMakefile.mk #230

Merged
merged 14 commits into from
Mar 5, 2024

Conversation

robin-aws
Copy link
Contributor

@robin-aws robin-aws commented Mar 2, 2024

Description of changes:

Replaces nearly all of SharedMakefileV2.mk with the new SmithyDafnyMakefile.mk from the smithy-dafny submodule. What's left is just the repo-specific configuration of variables.

See #233 for a more readable diff of the existing
SharedMakefileV2.mk with SmithyDafnyMakefile.mk, showing what targets are changing (which is very little as the extra target/improvements in the former were mostly carried over to the latter already).

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@robin-aws robin-aws marked this pull request as ready for review March 5, 2024 21:33
@robin-aws robin-aws requested a review from a team as a code owner March 5, 2024 21:33
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let it begin!

@robin-aws robin-aws merged commit df8c7e5 into main Mar 5, 2024
54 checks passed
@robin-aws robin-aws deleted the robin-aws/use-smithy-dafny-shared-makefile branch March 5, 2024 21:57
lucasmcdonald3 pushed a commit that referenced this pull request Jun 4, 2024
Replaces nearly all of `SharedMakefileV2.mk` with the new `SmithyDafnyMakefile.mk` from the `smithy-dafny` submodule. What's left is just the repo-specific configuration of variables.

See #233 for a more readable diff of the existing 
`SharedMakefileV2.mk` with `SmithyDafnyMakefile.mk`, showing what targets are changing (which is very little as the extra target/improvements in the former were mostly carried over to the latter already).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants