Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Python): Merge in remaining changes #550

Merged
merged 656 commits into from
Oct 2, 2024
Merged

chore(Python): Merge in remaining changes #550

merged 656 commits into from
Oct 2, 2024

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Jul 29, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  • Format all files. Only file changed is .releaserc.cjs.
  • Add Python changes to TestECDH.dfy
  • Bump to Smithy-Dafny head

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@lucasmcdonald3 lucasmcdonald3 changed the title [Draft] MPL review gap chore(Python): Merge in remaining changes Oct 2, 2024
@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review October 2, 2024 19:51
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner October 2, 2024 19:51
josecorella
josecorella approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

@lucasmcdonald3 and @josecorella, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@lucasmcdonald3 lucasmcdonald3 merged commit c571f51 into python-reviewed Oct 2, 2024
94 of 95 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the lucmcdon/python-mpl-v2 branch October 2, 2024 19:56
@lucasmcdonald3 lucasmcdonald3 restored the lucmcdon/python-mpl-v2 branch October 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecorella josecorella josecorella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmcdonald3 @josecorella