Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable name collision fix for Go #869

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ShubhamChaturvedi7
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 commented Oct 15, 2024

Issue #, if available:
https://t.corp.amazon.com/V1528740765

Description of changes:

The variable name ConditionExpression and the type ConditionExpression ends up colliding in Go. This PR uses cameCase for the variable name to avoid collision.

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ShubhamChaturvedi7 ShubhamChaturvedi7 marked this pull request as ready for review October 15, 2024 20:11
@ShubhamChaturvedi7 ShubhamChaturvedi7 requested a review from a team as a code owner October 15, 2024 20:11
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ShubhamChaturvedi7 ShubhamChaturvedi7 merged commit eb8592b into main Oct 15, 2024
95 checks passed
@ShubhamChaturvedi7 ShubhamChaturvedi7 deleted the variable_collision_fix_golang branch October 15, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants