Add S3BatchEventV2 #496
Merged
Add S3BatchEventV2 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm usually not a Java developer, so I'm unsure about best practices here, but I wanted to get something out there. I couldn't run the tests and would appreciate guidance on how to do that. |
|
Looks good to me. Thanks for your contribution @mmerfort |
maxday
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #495
Description of changes:
Add a new S3BatchEventV2 class representing an Event coming from S3 when using invocation schema version 2.
Compared to the other version, it adds the user arguments and changes the bucket ARN to the name.
Target (OCI, Managed Runtime, both):
Unsure yet
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.