Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PublicKeyComponents::build_encrypting_key #582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vadmeme
Copy link

@Vadmeme Vadmeme commented Nov 10, 2024

Issues:

Resolves #581

Description of changes:

Adds a PublicKeyComponents::build_encrypting_key.

Call-outs:

N/A

Testing:

Im not sure how to implement unit tests for this change would need a reviewer to assist with this. I tested them in my personal application and they functioned as expected.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.58%. Comparing base (c358484) to head (d0a9354).
Report is 105 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/rsa/key.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   95.80%   92.58%   -3.22%     
==========================================
  Files          61       67       +6     
  Lines        8143     9370    +1227     
  Branches        0     9370    +9370     
==========================================
+ Hits         7801     8675     +874     
- Misses        342      424      +82     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support importing RSA parameters manually for encryption with Pkcs1PublicEncryptingKey
2 participants