Lower required Go version, add CI test for specific version #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description of changes:
Add back support for Go 1.17.13 which is used by NetOS. Fix
a few language compatibility issues for interface{} and cmd
struct.
### Testing:
This change adds a new CI test which uses Go 1.17.13.
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
---------
Co-authored-by: Sean McGrail <[email protected]>
---------
Revert "Replace interface{} with any"
This reverts commit 6a90c15.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fips-NetOS-2024-06-11 #1725 +/- ##
=========================================================
- Coverage 78.13% 78.09% -0.05%
=========================================================
Files 562 562
Lines 94667 94667
Branches 13576 13585 +9
=========================================================
- Hits 73964 73926 -38
- Misses 20111 20147 +36
- Partials 592 594 +2 ☔ View full report in Codecov by Sentry. |
samuel40791765
approved these changes
Jul 26, 2024
nebeid
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add back support for Go 1.17.13 which is used by NetOS. Fix a few language compatibility issues for interface{} and cmd struct. This change does not affect the integrity value of the FIPS module.
Testing:
This change adds a new CI test which uses Go 1.17.13.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Co-authored-by: Sean McGrail [email protected]