Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine-Linux-x86 to GitHub Actions CI #1753

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Conversation

kexgaber
Copy link
Contributor

@kexgaber kexgaber commented Aug 8, 2024

Issues:

CryptoAlg-621
CryptoAlg-2262

Description of changes:

This adds a new job to the General CI GitHub Actions workflow to build and test AWS-LC on Alpine Linux (x86_64 architecture), using both Clang and GCC compilers. This ensures AWS-LC remains compatible with musl-based systems, such as Alpine.

Call-outs:

  • When ARM-powered runners are made generally available, this job can be expanded to also target the arm64 architecture.

Testing:

This new job runs the existing tests found in tests/ci/run_posix_tests.sh and tests/ci/run_fips_tests.sh

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (bda01b4) to head (13056d9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
- Coverage   78.49%   78.48%   -0.01%     
==========================================
  Files         585      585              
  Lines       99630    99630              
  Branches    14253    14254       +1     
==========================================
- Hits        78201    78199       -2     
- Misses      20794    20796       +2     
  Partials      635      635              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kexgaber kexgaber marked this pull request as ready for review August 9, 2024 01:17
@kexgaber kexgaber requested a review from a team as a code owner August 9, 2024 01:17
@kexgaber kexgaber requested a review from skmcgrail August 9, 2024 01:17
skmcgrail
skmcgrail previously approved these changes Aug 9, 2024
.github/docker_images/alpine-linux/entry.sh Outdated Show resolved Hide resolved
.github/workflows/actions-ci.yml Outdated Show resolved Hide resolved
@chipitsine
Copy link
Contributor

I'd suggest to use more native way like this one

https://github.com/haproxy/haproxy/blob/master/.github/workflows/musl.yml#L13-L14

@justsmth justsmth enabled auto-merge (squash) October 7, 2024 18:52
@justsmth justsmth merged commit 6bd8da9 into aws:main Oct 7, 2024
112 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants