P-256 scalar mul and modular inverse from s2n-bignum #1794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
This makes use of s2n-bignum's P-256 functions for both the fresh-point scalar multiplication and the modular (actually Montgomery) inverse that arises in conversion from Jacobian to affine.
Call-outs:
Basic #if/#else/#endif versioning is a bit crude and maybe there is a better way to do this stylistically.
Only tested on a few platforms and may need more work to make it completely portable, robust for FIPS builds etc.
Testing:
Ran "ninja run_tests" and a few other aws-lc tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.