Implement PKCS7_dataInit and PKCS7_dataFinal #1816
Open
+870
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1816 +/- ##
==========================================
- Coverage 78.79% 78.74% -0.05%
==========================================
Files 590 590
Lines 101506 101870 +364
Branches 14401 14448 +47
==========================================
+ Hits 79979 80220 +241
- Misses 20891 21014 +123
Partials 636 636 ☔ View full report in Codecov by Sentry. |
WillChilds-Klein
force-pushed
the
pkcs7-bio-data-init-final
branch
3 times, most recently
from
23e4d39
to
1b0c84d
Compare
WillChilds-Klein
force-pushed
the
pkcs7-bio-data-init-final
branch
from
1b0c84d
to
b7ffbde
Compare
WillChilds-Klein
force-pushed
the
pkcs7-bio-data-init-final
branch
from
b7ffbde
to
69cb0fd
Compare
WillChilds-Klein
force-pushed
the
pkcs7-bio-data-init-final
branch
5 times, most recently
from
a4a9d39
to
f7c09cf
Compare
WillChilds-Klein
changed the title
WillChilds-Klein
force-pushed
the
pkcs7-bio-data-init-final
branch
from
f7c09cf
to
aa9a47c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR adds a few new functions, most notably
PKCS7_dataInitandPKCS7_dataFinalas they're used by ruby to prepare/finalize BIO chains for reading from or writing to a PKCS7 object. Their usage is documented here inpkcs7.h.Testing
Coverage in this PR itself is a bit low due to the cipher-related initialization in PKCS7_dataInit and signature-related finalization in PKCS7_dataFinal. Coverage for these sections of code will be added in the next 2 PRs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.