Check for null return pointers in pem_test.cc #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1855 +/- ##
=======================================
Coverage 78.51% 78.52%
=======================================
Files 583 583
Lines 98809 98809
Branches 14159 14160 +1
=======================================
+ Hits 77583 77590 +7
+ Misses 20598 20591 -7
Partials 628 628 ☔ View full report in Codecov by Sentry. |
justsmth
approved these changes
Sep 17, 2024
samuel40791765
approved these changes
Sep 17, 2024
darylmartin100
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves P154590111
Description of changes:
Static analysis found a few cases where these tests could fail due to dereferencing null, if a null pointer ever shows up here the test will still fail, but now more gracefully.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.