Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-KEM encapsulation key modulus check #1868

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dkostic
Copy link
Contributor

@dkostic dkostic commented Sep 20, 2024

Issues:

CryptoAlg-2620

Description of changes:

ML-KEM encapsulation key modulus check as specified in FIPS 203 Section 7.2.
https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.203.pdf

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@dkostic dkostic requested a review from a team as a code owner September 20, 2024 20:09
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (7090b90) to head (c559789).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1868   +/-   ##
=======================================
  Coverage   78.46%   78.47%           
=======================================
  Files         585      585           
  Lines       99457    99506   +49     
  Branches    14236    14247   +11     
=======================================
+ Hits        78038    78085   +47     
- Misses      20784    20786    +2     
  Partials      635      635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkostic dkostic changed the title ML-KEM encapsulation key check per FIPS 203 ML-KEM encapsulation key modulus check Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants