Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node debugger protocol #358

Merged
merged 3 commits into from
Apr 11, 2018

Conversation

bradydowling
Copy link
Contributor

Issue #, if available:
Pertains to this comment made on this PR.

Description of changes:
Changes the run command for Node.js version 6.10 to use the legacy debugger (as it previously did) instead of the inspector debugger. Includes directions in the README for when to use legacy and when to use inspector in your launch configuration in VSCode.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bradydowling
Copy link
Contributor Author

As some background for this change, inspector does not report end of execution (in Node 6.10) so the debugger never knows when to disconnect. This PR was made and merged for Node 7+ but never backported to Node 6.10. Because of this, IDEs can't know when the debugger should detach if they're using inspector for Node6.x or below.

@bradydowling
Copy link
Contributor Author

See also the official Node docs on debugging that mentions:

The legacy debugger has been deprecated as of Node 7.7.0. Please use --inspect and Inspector instead.

@bradydowling
Copy link
Contributor Author

Lastly, it's worth noting that the previous change to inspector was prompted by a bug in VSCode. That bug has since been fixed (see comment from previous PR).

Copy link
Contributor

@sanathkr sanathkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense. I also pulled the PR locally, verified using VSCode that this fix works.

I also added a fix for Node8 to make debugging actually work

@sanathkr sanathkr merged commit a04b791 into aws:develop Apr 11, 2018
qingchm pushed a commit to qingchm/aws-sam-cli that referenced this pull request Sep 17, 2021
* Added Locking to Layer Building

* Fixed LockChain Exception

* Added Comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants