Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin MarkupSafe to 2.0.1 #3662

Merged
merged 1 commit into from
Feb 18, 2022
Merged

fix: Pin MarkupSafe to 2.0.1 #3662

merged 1 commit into from
Feb 18, 2022

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Feb 18, 2022

Which issue(s) does this change fix?

#3661

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

  • Add input/output type hints to new functions/methods
  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@CoshUS CoshUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update reproducible-linux.txt as well?

@jfuss
Copy link
Contributor Author

jfuss commented Feb 18, 2022

@CoshUS

We can but I prefer to do that under the "upgrade all our dependencies" since our installers are not impacted: https://github.com/aws/aws-sam-cli/blob/develop/requirements/reproducible-linux.txt#L131

@jfuss jfuss merged commit f646ac5 into aws:develop Feb 18, 2022
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants