Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose client configuration through api factory #158

Merged
merged 4 commits into from
Jun 27, 2016
Merged

Expose client configuration through api factory #158

merged 4 commits into from
Jun 27, 2016

Conversation

fgoncalves
Copy link
Contributor

In our code base we found it very useful to expose the ClientConfiguration through the ApiClientFactory. This let's us for example set the user agent for all our calls since we do a lot of client identification based on this header.

We'd like to propose this change. We didn't break the contract and respected the method chaining previously there. One can set the configuration as such:

new ApiClientFactory()
                .clientConfiguration(clientConfiguration)
                .endpoint("some endpoint");

Thank you

@AutomatedPlayground
Copy link

+:b:

@laurens
Copy link

laurens commented Jun 27, 2016

+1 thanks!

@fosterzhang
Copy link
Contributor

Make sense. Thank you.

@fosterzhang fosterzhang merged commit 66e5a23 into aws-amplify:master Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants