Clean up and update old scripts #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
approved these changes
Sep 1, 2022
sbiscigl
reviewed
Sep 1, 2022
| '|.*tests/.*Test.cpp' | ||
| # add more white lists here | ||
| ) | ||
| if skip_file_pattern.match(filename): |
There was a problem hiding this comment.
could simplify to return skip_file_pattern.match(filename)
There was a problem hiding this comment.
Submitted a new PR with this change and some whitespace adjustments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1888
Description of changes:
Adjusted scripts to be more "python-3" friendly, added a few basic refactors to be PEP8 compliant. Removed old unused scripts. This is preparation for follow up changes.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.