Skip to content

Commit

Permalink
Fix misaligned struct member used in atomic operation (#2519)
Browse files Browse the repository at this point in the history
  • Loading branch information
dswarbrick authored Mar 4, 2024
1 parent 530583e commit 1ad34b3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
8 changes: 8 additions & 0 deletions .changelog/448aaf1509f448d385e5c243933a39d8.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "448aaf15-09f4-48d3-85e5-c243933a39d8",
"type": "bugfix",
"description": "Fix misaligned struct member used in atomic operation. This fixes a panic caused by attempting to atomically access a struct member which is not 64-bit aligned when running on 32-bit arch, due to the smaller sync.Map struct.",
"modules": [
"service/internal/endpoint-discovery"
]
}
6 changes: 3 additions & 3 deletions service/internal/endpoint-discovery/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ import (
// based on some key. The data structure makes use of a read write
// mutex to enable asynchronous use.
type EndpointCache struct {
endpoints sync.Map
endpointLimit int64
// size is used to count the number elements in the cache.
// The atomic package is used to ensure this size is accurate when
// using multiple goroutines.
size int64
size int64
endpoints sync.Map
endpointLimit int64
}

// NewEndpointCache will return a newly initialized cache with a limit
Expand Down

0 comments on commit 1ad34b3

Please sign in to comment.