Skip to content

Commit

Permalink
Suppress WriterAt which can bypass Windows optimizations.
Browse files Browse the repository at this point in the history
  • Loading branch information
AWS SDK for Go v2 automation user authored and skmcgrail committed Aug 5, 2022
1 parent 2552ca4 commit d66badf
Show file tree
Hide file tree
Showing 18 changed files with 56 additions and 42 deletions.
8 changes: 0 additions & 8 deletions .changelog/1777f2ba22d94da291eac62fdc68462f.json

This file was deleted.

8 changes: 0 additions & 8 deletions .changelog/29775ce590cf4f2bbec1fece0c7aa8b2.json

This file was deleted.

8 changes: 0 additions & 8 deletions .changelog/4555e36152664886b9398464c0a4b8f8.json

This file was deleted.

8 changes: 0 additions & 8 deletions .changelog/f05455d1526749acb164b2d755e955b0.json

This file was deleted.

12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# Release (2022-08-04)

## Module Highlights
* `github.com/aws/aws-sdk-go-v2/service/chimesdkmeetings`: [v1.13.0](service/chimesdkmeetings/CHANGELOG.md#v1130-2022-08-04)
* **Feature**: Adds support for Tags on Amazon Chime SDK WebRTC sessions
* `github.com/aws/aws-sdk-go-v2/service/configservice`: [v1.24.0](service/configservice/CHANGELOG.md#v1240-2022-08-04)
* **Feature**: Add resourceType enums for Athena, GlobalAccelerator, Detective and EC2 types
* `github.com/aws/aws-sdk-go-v2/service/databasemigrationservice`: [v1.21.3](service/databasemigrationservice/CHANGELOG.md#v1213-2022-08-04)
* **Documentation**: Documentation updates for Database Migration Service (DMS).
* `github.com/aws/aws-sdk-go-v2/service/iot`: [v1.28.0](service/iot/CHANGELOG.md#v1280-2022-08-04)
* **Feature**: The release is to support attach a provisioning template to CACert for JITP function, Customer now doesn't have to hardcode a roleArn and templateBody during register a CACert to enable JITP.

# Release (2022-08-03)

## Module Highlights
Expand Down
10 changes: 8 additions & 2 deletions feature/s3/manager/download.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ func WithDownloaderClientOptions(opts ...func(*s3.Options)) func(*Downloader) {
// interface.
//
// Example:
// // Load AWS Config
//
// // Load AWS Config
// cfg, err := config.LoadDefaultConfig(context.TODO())
// if err != nil {
// panic(err)
Expand Down Expand Up @@ -153,6 +154,7 @@ func NewDownloader(c DownloadAPIClient, options ...func(*Downloader)) *Downloade
// and GC runs.
//
// Example:
//
// // pre-allocate in memory buffer, where headObject type is *s3.HeadObjectOutput
// buf := make([]byte, int(headObject.ContentLength))
// // wrap with aws.WriteAtBuffer
Expand Down Expand Up @@ -397,7 +399,11 @@ func (d *downloader) tryDownloadChunk(params *s3.GetObjectInput, w io.Writer) (i
}
d.setTotalBytes(resp) // Set total if not yet set.

n, err := io.Copy(w, resp.Body)
var src io.Reader = resp.Body
if d.cfg.BufferProvider != nil {
src = &suppressWriterAt{suppressed: src}
}
n, err := io.Copy(w, src)
resp.Body.Close()
if err != nil {
return n, &errReadingBody{err: err}
Expand Down
8 changes: 8 additions & 0 deletions feature/s3/manager/writer_read_from.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,11 @@ func (p *PooledBufferedReadFromProvider) GetReadFrom(writer io.Writer) (r Writer
}
return r, cleanup
}

type suppressWriterAt struct {
suppressed io.Reader
}

func (s *suppressWriterAt) Read(p []byte) (n int, err error) {
return s.suppressed.Read(p)
}
4 changes: 4 additions & 0 deletions service/chimesdkmeetings/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# v1.13.0 (2022-08-04)

* **Feature**: Adds support for Tags on Amazon Chime SDK WebRTC sessions

# v1.12.1 (2022-08-01)

* **Dependency Update**: Updated to the latest SDK module versions
Expand Down
2 changes: 1 addition & 1 deletion service/chimesdkmeetings/go_module_metadata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions service/computeoptimizer/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# v1.17.11 (2022-08-04)

* No change notes available for this release.

# v1.17.10 (2022-08-01)

* **Dependency Update**: Updated to the latest SDK module versions
Expand Down
2 changes: 1 addition & 1 deletion service/computeoptimizer/go_module_metadata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions service/configservice/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# v1.24.0 (2022-08-04)

* **Feature**: Add resourceType enums for Athena, GlobalAccelerator, Detective and EC2 types

# v1.23.1 (2022-08-01)

* **Documentation**: Documentation update for PutConfigRule and PutOrganizationConfigRule
Expand Down
2 changes: 1 addition & 1 deletion service/configservice/go_module_metadata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions service/databasemigrationservice/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# v1.21.3 (2022-08-04)

* **Documentation**: Documentation updates for Database Migration Service (DMS).

# v1.21.2 (2022-08-01)

* **Dependency Update**: Updated to the latest SDK module versions
Expand Down
2 changes: 1 addition & 1 deletion service/databasemigrationservice/go_module_metadata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions service/internal/integrationtest/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ require (
github.com/aws/aws-sdk-go-v2/service/codepipeline v1.13.9
github.com/aws/aws-sdk-go-v2/service/codestar v1.11.9
github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider v1.18.0
github.com/aws/aws-sdk-go-v2/service/configservice v1.23.1
github.com/aws/aws-sdk-go-v2/service/configservice v1.24.0
github.com/aws/aws-sdk-go-v2/service/costandusagereportservice v1.13.9
github.com/aws/aws-sdk-go-v2/service/databasemigrationservice v1.21.2
github.com/aws/aws-sdk-go-v2/service/databasemigrationservice v1.21.3
github.com/aws/aws-sdk-go-v2/service/devicefarm v1.13.9
github.com/aws/aws-sdk-go-v2/service/directconnect v1.17.9
github.com/aws/aws-sdk-go-v2/service/directoryservice v1.14.3
Expand All @@ -50,7 +50,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/health v1.15.12
github.com/aws/aws-sdk-go-v2/service/iam v1.18.10
github.com/aws/aws-sdk-go-v2/service/inspector v1.12.9
github.com/aws/aws-sdk-go-v2/service/iot v1.27.1
github.com/aws/aws-sdk-go-v2/service/iot v1.28.0
github.com/aws/aws-sdk-go-v2/service/kinesis v1.15.10
github.com/aws/aws-sdk-go-v2/service/kms v1.18.1
github.com/aws/aws-sdk-go-v2/service/lambda v1.23.5
Expand Down
4 changes: 4 additions & 0 deletions service/iot/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# v1.28.0 (2022-08-04)

* **Feature**: The release is to support attach a provisioning template to CACert for JITP function, Customer now doesn't have to hardcode a roleArn and templateBody during register a CACert to enable JITP.

# v1.27.1 (2022-08-01)

* **Dependency Update**: Updated to the latest SDK module versions
Expand Down
2 changes: 1 addition & 1 deletion service/iot/go_module_metadata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d66badf

Please sign in to comment.