Skip to content

Commit

Permalink
Fix SDK's API model sync utility to ignore models without sdkId (#1459)
Browse files Browse the repository at this point in the history
Updates the SDK's API model sync utility to ignore modeled service
shapes that do not have a `sdkId` or `aws.api#service` trait.
  • Loading branch information
jasdel authored Oct 18, 2021
1 parent 973e5f5 commit f8d40e3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/repotools/cmd/syncAPIModels/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ func findSmithyModels(modelPath string) (map[string]SourceModel, error) {
name, path)
}
if shape.Traits.Service == nil {
return fmt.Errorf("smithy service doesn't have service trait %s, %s",
name, path)
// Ignore services that don't have an SDK id.
continue
}
if len(shape.Traits.Service.SDKID) == 0 {
return fmt.Errorf("smithy service doesn't have sdkId value %s, %s",
Expand Down

0 comments on commit f8d40e3

Please sign in to comment.