Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializers: use of illegal fallthrough statement in a type switch #978

Closed
skotambkar opened this issue Dec 14, 2020 · 2 comments · Fixed by #979
Closed

serializers: use of illegal fallthrough statement in a type switch #978

skotambkar opened this issue Dec 14, 2020 · 2 comments · Fixed by #979
Assignees
@skotambkar
Labels
bug This issue is a bug.
Milestone
v1.0 Release Cand...

Comments

@skotambkar
Copy link
Contributor

skotambkar commented Dec 14, 2020 •
edited
Loading

We use fallthrough in a type switch statement in union serializers. Needs a simple fix to not use fallthrough for unknown types, andjust use the default statement.
@skotambkar skotambkar added the bug This issue is a bug. label Dec 14, 2020
@skotambkar skotambkar added this to the v1.0 Release Candidate milestone Dec 14, 2020
@skotambkar skotambkar self-assigned this Dec 14, 2020
@skotambkar
Copy link
Contributor Author

fixed in #979

@jasdel jasdel mentioned this issue Dec 15, 2020
Merged
jasdel added a commit that referenced this issue Dec 15, 2020
@jasdel
codegen: fix union serialization cases (#979)
4806b72 
Fixes the cases of generated union serializer functions to use the correct types for union members.

Fixes #978
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skotambkar skotambkar

Labels
bug This issue is a bug.
Projects
None yet
Milestone
v1.0 Release Candidate
Development

Successfully merging a pull request may close this issue.

codegen: fix union serialization cases jasdel/aws-sdk-go-v2
1 participant
@skotambkar