aws/signer/v4: Fix presign hoisting for x-amz-tagging header #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The x-amz-tagging header should not be hoisted to the query string and must be sent as a signed header. If the value is hoisted to the query string in a presigned Put, it is ignored by Amazon S3.
skotambkar
reviewed
Jan 5, 2021
| @@ -53,6 +53,7 @@ var RequiredSignedHeaders = Rules{ | |||
| "X-Amz-Storage-Class": struct{}{}, | |||
| "X-Amz-Website-Redirect-Location": struct{}{}, | |||
| "X-Amz-Content-Sha256": struct{}{}, | |||
| "X-Amz-Tagging": struct{}{}, | |||
There was a problem hiding this comment.
- Is this a valid change for any other rest based service apart from
s3which use this Header?
There was a problem hiding this comment.
Yeah this would be valid for all other services, as not hoisting headers is valid approach. In addition S3 is the only service that sends this header for a presigned url.
skotambkar
approved these changes
Jan 5, 2021
skmcgrail
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
x-amz-taggingheader should not be hoisted to the query string and must be sent as a signed header. If the value is hoisted to the query string in a presigned Put, it is ignored by Amazon S3.Fixes #1016