Fix searching for namespaced xml attrs #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
added a commit
to jasdel/smithy
that referenced
this pull request
Jan 12, 2021
Adds additional protocol tests for member bound to XML attribute within a struct that also has an XML namespace. Related to aws/smithy-go#255, aws/aws-sdk-go-v2#1034, aws/aws-sdk-go-v2#1013
jasdel
approved these changes
Jan 12, 2021
...aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/XmlShapeDeserVisitor.java
Outdated
Show resolved
Hide resolved
JordonPhillips
pushed a commit
to smithy-lang/smithy
that referenced
this pull request
Jan 13, 2021
Adds additional protocol tests for member bound to XML attribute within a struct that also has an XML namespace. Related to aws/smithy-go#255, aws/aws-sdk-go-v2#1034, aws/aws-sdk-go-v2#1013
This adds a skip for the test that covers sending xml with a namespaced attribute. The bug is real and needs to be fixed, but currently no service is impacted and so the impactful fix to the deserialization of the same needs to go out asap.
jasdel
force-pushed
the
used-heald-attr
branch
from
b09c035
to
a61e359
Compare
skotambkar
approved these changes
Jan 14, 2021
skmcgrail
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1013, and requires aws/smithy-go#255 before it will properly pass.