Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Updates SDK's generated serde for unmodeled operation input/output #1050

Merged
merged 4 commits into from
Jan 16, 2021
Merged

codegen: Updates SDK's generated serde for unmodeled operation input/output #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af1f43f
codegen: Update AwsQuery and JSONRPC protocols to skip empty inputs
jasdel Jan 15, 2021
c2a3196
regenerate API
jasdel Jan 15, 2021
1b15855
fixup usaged of SyntheticClone to be optional archetype
jasdel Jan 15, 2021
de3108d
fixup integration tests
jasdel Jan 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...n/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ protected void serializeInputDocument(GenerationContext context, OperationShape
writer.openBlock("if err := $L(input, bodyEncoder.Value); err != nil {", "}", functionName, () -> {
writer.write("return out, metadata, &smithy.SerializationError{Err: err}");
}).write("");
} else {
writer.write("_ = input");
writer.write("");
}

writer.write("err = bodyEncoder.Encode()");
Expand Down
2 changes: 0 additions & 2 deletions ...codegen/src/main/java/software/amazon/smithy/aws/go/codegen/JsonRpcProtocolGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ protected void serializeInputDocument(GenerationContext context, OperationShape

// If there are no members then there's nothing to serialize
if (input.members().size() == 0) {
// Prevent warnings caused by input not being used
writer.write("_ = input");
return;
}

Expand Down
4 changes: 3 additions & 1 deletion ...-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/XmlProtocolUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,9 @@ private static String getSerializedXMLShapeName(ProtocolGenerator.GenerationCont
Optional<SyntheticClone> clone = shape.getTrait(SyntheticClone.class);
if (clone.isPresent()) {
SyntheticClone cl = clone.get();
shapeName = cl.getArchetype().getName();
if (cl.getArchetype().isPresent()) {
shapeName = cl.getArchetype().get().getName();
}
jasdel marked this conversation as resolved.
Show resolved Hide resolved
}

// check if shape is member shape
Expand Down
54 changes: 54 additions & 0 deletions internal/protocoltest/awsrestjson/deserializers.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading