Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Single Sign-On (SSO) Provider Support #1072

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Jan 23, 2021

Adds support for the AWS Single Sign-On (SSO) service by supporting the ability to utilize tokens cached in ~/.aws/sso/cache.

Adds support for the AWS SSO provider in the default credential loading chain.

Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good couple suggestions, mainly with gofmt/go lint.

config/load_options.go Outdated Show resolved Hide resolved
config/resolve_credentials.go Outdated Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
credentials/ssocreds/doc.go Outdated Show resolved Hide resolved
credentials/ssocreds/os.go Show resolved Hide resolved
credentials/ssocreds/provider.go Show resolved Hide resolved
credentials/ssocreds/doc.go Outdated Show resolved Hide resolved
credentials/ssocreds/provider.go Outdated Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
config/shared_config_test.go Show resolved Hide resolved
credentials/ssocreds/os_windows.go Show resolved Hide resolved
credentials/ssocreds/provider_test.go Outdated Show resolved Hide resolved
config/resolve_credentials_test.go Show resolved Hide resolved
config/resolve_credentials_test.go Outdated Show resolved Hide resolved
config/shared_config_test.go Show resolved Hide resolved
Copy link
Contributor

@skotambkar skotambkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@skmcgrail skmcgrail force-pushed the ssoProvider branch 6 times, most recently from 68b819c to 670cd99 Compare January 27, 2021 00:39
@skmcgrail skmcgrail merged commit e8777b6 into aws:main Jan 27, 2021
@skmcgrail skmcgrail deleted the ssoProvider branch January 27, 2021 23:39
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants