Adds Policy and Duration parameters to stscreds.WebIdentityRoleOptions
#1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
sts-assumerolewithwebidentityprovider-policy
branch
from
67edb47
to
dc0d996
Compare
jasdel
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Thanks for taking the time to create this PR @gdavison the change looks good. I've also updated the handling of WebIdentityRoleOptions.Duration to only be assigned to AssumeRoleWithWebIdentityInput.DurationSeconds if the Duration option is not 0. Relying on STS to handle assigning a default value when the DurationSeconds parameter is not in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
PolicyandDurationparameters fromsts.AssumeRoleWithWebIdentityInputtostscreds.WebIdentityRoleOptions.Closes #1662