fix: fail to load config if configured profile doesn't exist #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Oct 10, 2023
isaiahvita
reviewed
Oct 11, 2023
| if os.Getenv(awsProfileEnvVar) != "" || options.SharedConfigProfile != "" { | ||
| loaders[1] = loadSharedConfig | ||
| } else { | ||
| loaders[1] = loadSharedConfigIgnoreNotExist |
There was a problem hiding this comment.
am i missing something here? the behavior looks the same: its still using the loadSharedConfigIgnoreNotExist which swallows the error (i.e. doesnt return an error message).
There was a problem hiding this comment.
Unless the check on 204 is true though (which means a profile was specified). That's the change here.
isaiahvita
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2058.
This isn't really possible to unit test in a meaningful way since we don't have well-defined os/fs separations in our config loading unit tests. I've verified it manually, however.