feat: rollout generated waiters for ec2 #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Jul 17, 2024
Madrigal
approved these changes
Jul 18, 2024
| import static software.amazon.smithy.go.codegen.SymbolUtils.buildPackageSymbol; | ||
|
|
||
| public class AwsWaiters2 extends Waiters2 { | ||
| public static final List<ShapeId> PHASED_ROLLOUT_SERVICES = List.of( |
There was a problem hiding this comment.
[nit] likely irrelevant due to small n, but this is definitely a use case for a Set
| pathValue, err := jmespath.Search("BundleTasks[].State", output) | ||
| if err != nil { | ||
| return false, fmt.Errorf("error evaluating waiter state: %w", err) | ||
| v1 := output.BundleTasks |
There was a problem hiding this comment.
[no-op] I like that there are no type assertions with this new generator
lucix-aws
force-pushed
the
feat-waiters2rollout
branch
from
c6adcb0
to
c827b6f
Compare
lucix-aws
force-pushed
the
feat-waiters2rollout
branch
from
c827b6f
to
7e318ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables new, generated waiters for the EC2 service. We intend to let this bake for a few weeks before following up with more/all other services.