Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presignedurl requestpayer change #2768

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Presignedurl requestpayer change #2768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37a0bef
removed requestpayer from RequiredSignedHeaders
bhavya2109sharma Aug 30, 2024
cd701b8
Removed Comments
bhavya2109sharma Aug 30, 2024
0353706
Added Changelog
bhavya2109sharma Aug 30, 2024
d4bd42f
Merge branch 'main' into presignedurl-requestpayer-change
lucix-aws Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changelog/d85bd7ce7f754e159b33ac402f217a7c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "d85bd7ce-7f75-4e15-9b33-ac402f217a7c",
"type": "bugfix",
"description": "Change requestPayer behaviour from signedHeader to hoisted query parameter ",
"modules": [
"."
]
}
1 change: 0 additions & 1 deletion aws/signer/internal/v4/headers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ var RequiredSignedHeaders = Rules{
"X-Amz-Grant-Write-Acp": struct{}{},
"X-Amz-Metadata-Directive": struct{}{},
"X-Amz-Mfa": struct{}{},
"X-Amz-Request-Payer": struct{}{},
"X-Amz-Server-Side-Encryption": struct{}{},
"X-Amz-Server-Side-Encryption-Aws-Kms-Key-Id": struct{}{},
"X-Amz-Server-Side-Encryption-Context": struct{}{},
Expand Down
Loading