codegen: Add support for REST-XML Union responses #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
fixup/XMLUnions
branch
2 times, most recently
from
dc365f5
to
b8a2ca6
Compare
skmcgrail
approved these changes
Dec 22, 2020
skmcgrail
reviewed
Dec 22, 2020
...aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/XmlShapeDeserVisitor.java
Outdated
Show resolved
Hide resolved
Adds support for deserializing REST-XML union resources Fixes aws#939 Related to smithy-lang/smithy#678
jasdel
force-pushed
the
fixup/XMLUnions
branch
from
b8a2ca6
to
36f936f
Compare
skmcgrail
approved these changes
Dec 22, 2020
skotambkar
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for deserializing REST-XML union resources.
Gist of change: https://gist.github.com/jasdel/e19f2ba4cb595366bd47e4112f8c4266
Fixes #939
Related to smithy-lang/smithy#678
Depends on fix for #910