-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/ini: Fix ini parser to handle empty values #2860
Conversation
I think the failing Go 1.7 test is fixed in PR #2841 once that pr is merged should be able to rebase and rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the description on why the ini parser change fixes the issue? This might help investigate future issues.
also should this PR include the ini_parser_test.go
update in #2801?
b8f048b
to
20c815f
Compare
20c815f
to
fbe7c7c
Compare
Ensure HTTP servers are cleaned up during testing after no longer needed. This was creating excessive noise in testing stack traces due to the number of background goroutines active. Also updated SDK's unit tests to use verbose logging, have shorter runtime, and have a timeout fo 5m. Related to aws#2840
1dc49a0
to
a681c05
Compare
a681c05
to
fc55aa5
Compare
The ini parser incorrectly decided whether a statement should be skipped. As a result, valid statements in the ini files were being squashed. The PR fixes incorrect modifications to the previous token value of the skipper. We also add checks for cases where a skipped statement should be marked as complete and not be ignored.
Adds test cases for cases for statements that need to be skipped. Also adds suggested tests from #2801 . Fixes #2800