Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/s3control: Fix GetAccessPointPolicy, DeleteAccessPointPolicy, and PutAccessPointPolicy operations not routing properly for S3 on Outposts #3599

Merged
merged 1 commit into from
Oct 15, 2020
Merged

service/s3control: Fix GetAccessPointPolicy, DeleteAccessPointPolicy, and PutAccessPointPolicy operations not routing properly for S3 on Outposts #3599

merged 1 commit into from
Oct 15, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 15, 2020 •
edited
Loading

Reference: #3598

@bflad
service/s3control: Fix GetAccessPointPolicy, DeleteAccessPointPolicy,…
4211710 
… and PutAccessPointPolicy operations not routing properly for S3 on Outposts

Reference: aws#3598
@bflad bflad mentioned this pull request Oct 15, 2020
Closed
3 tasks
@bflad
Copy link
Contributor Author

bflad commented Oct 15, 2020

It's not clear from the API model whether GetAccessPointPolicyStatusInput should also get the same customization. It may not need it though since access point policies cannot be public in S3 on Outposts.

skotambkar
skotambkar approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@skotambkar skotambkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for letting us know about the bug, and submitting a PR with the fix. The changes looks good to me!

@skotambkar skotambkar merged commit b8ee473 into aws:master Oct 15, 2020
aws-sdk-go-automation pushed a commit that referenced this pull request Oct 16, 2020
Release v1.35.9 (2020-10-16)
fd8b59f 
===

### Service Client Updates
* `service/medialive`: Updates service API, documentation, and paginators
  * The AWS Elemental MediaLive APIs and SDKs now support the ability to transfer the ownership of MediaLive Link devices across AWS accounts.
* `service/organizations`: Updates service documentation
  * Documentation updates for AWS Organizations.

### SDK Bugs
* `s3control`: Fixes bug in SDK that caused GetAccessPointPolicy, DeleteAccessPointPolicy, and PutAccessPointPolicy operations to not route properly for S3 on Outposts. ([#3599](#3599))
  * Fixes [#3598](#3598).
@aws-sdk-go-automation aws-sdk-go-automation mentioned this pull request Oct 16, 2020
Merged
aws-sdk-go-automation added a commit that referenced this pull request Oct 16, 2020
@aws-sdk-go-automation
Release v1.35.9 (2020-10-16) (#3601)
759fc2c 
Release v1.35.9 (2020-10-16)
===

### Service Client Updates
* `service/medialive`: Updates service API, documentation, and paginators
  * The AWS Elemental MediaLive APIs and SDKs now support the ability to transfer the ownership of MediaLive Link devices across AWS accounts.
* `service/organizations`: Updates service documentation
  * Documentation updates for AWS Organizations.

### SDK Bugs
* `s3control`: Fixes bug in SDK that caused GetAccessPointPolicy, DeleteAccessPointPolicy, and PutAccessPointPolicy operations to not route properly for S3 on Outposts. ([#3599](#3599))
  * Fixes [#3598](#3598).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skmcgrail skmcgrail skmcgrail approved these changes

@skotambkar skotambkar skotambkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @skmcgrail @skotambkar