-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awsQueryCompatible error code translation support #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or code if the query error code header is present
skmcgrail
reviewed
Nov 18, 2022
isaiahvita
previously approved these changes
Dec 5, 2022
isaiahvita
dismissed
their stale review
December 6, 2022 23:41
it appears that the existing PR will break customers
isaiahvita
reviewed
Dec 13, 2022
isaiahvita
reviewed
Dec 15, 2022
private/model/api/codegentest/models/awsquerycompatible/api-2.json
Outdated
Show resolved
Hide resolved
private/model/api/codegentest/service/awsquerycompatible/awsquerycompatible_test.go
Outdated
Show resolved
Hide resolved
private/model/api/codegentest/service/awsquerycompatible/awsquerycompatible_test.go
Show resolved
Hide resolved
isaiahvita
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The awsQueryCompatible error code is returned if the error header is found in the response. This is a pre-requisite for migrating services from AWSQuery wire protocol to AWSJson. Detailed description of this change if AWSQueryCompatible trait is present:
code
fieldCode()
function would return a non-emptycode
value, else returns the default valueA test service has been generated for validating assumptions. Added unit tests as per the SEP.