Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for service endpoint overrides #65

Merged
merged 2 commits into from
Jan 20, 2015

Conversation

marceldegraaf
Copy link
Contributor

This pull request adds support for service endpoint overrides. To add an override, import github.com/stripe/aws-go/gen/endpoints in your code, and call endpoints.AddOverride(<service>, <region>, <uri>):

endpoints.AddOverride("EC2", "test-1", "http://localhost:3000")

Fixes #63

This makes it easier to write tests for Go code that uses aws-go, e.g. by starting a local mock SQS/SNS/DynamoDB service to test against.
stripecodahale added a commit that referenced this pull request Jan 20, 2015
Add support for service endpoint overrides
@stripecodahale stripecodahale merged commit fdd70e6 into aws:master Jan 20, 2015
@stripecodahale
Copy link
Contributor

Awesome, thanks.

@stripecodahale
Copy link
Contributor

Oh, sorry. I'm going to have to back this out. I didn't see that it's a change to a generated file. I'll merge this functionality in myself.

@marceldegraaf
Copy link
Contributor Author

Ah, that file is generated as well? I thought it wasn't, because it doesn't have the telltale comment at the top :-). 

I can also update the PR with a correct implementation if you want?

On Tue, Jan 20, 2015 at 11:36 PM, Coda Hale [email protected]
wrote:

Oh, sorry. I'm going to have to back this out. I didn't see that it's a change to a generated file. I'll merge this functionality in myself.

Reply to this email directly or view it on GitHub:
#65 (comment)

@stripecodahale
Copy link
Contributor

I added the warning in c3701e6 and 902d3ec, and added the overrides in e8ad61e, so you should be good to go.

@marceldegraaf
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting local (mock) AWS endpoints for testing
2 participants