Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Create overloaded methods in DynamoDBMapper to set RequestMetricCollector for each operation #703

Closed
swaranga opened this issue Sep 14, 2018 · 5 comments
Labels
2.0 New feature-request A feature should be added or improved.

Comments

@swaranga
Copy link

We should have the ability to collect DynamoDB service call metrics even when using the DynamoDBMapper library. Note that while I can attach a client level RequestMetricCollector directly to the underlying DynamoDB client, this is not sufficient because I need to collect metrics based on calls to my service and having the ability to attach a metric collector at runtime is what solves the problem for me.

@dagnir
Copy link
Contributor

dagnir commented Sep 14, 2018

Related to #35

@SeekerWing
Copy link

SeekerWing commented Nov 30, 2018

i'm not too sure if its directly related to #35

this feature request is not limited to DynamoDBMapper. in v1 all AwsClientBuilder and AmazonWebServiceRequest objects provided for the client to provide a RequestMetricCollector

v2 should provide for the same.

in fact this looks like more of a feature request to support sdk metrics in 2.0

@dagnir
Copy link
Contributor

dagnir commented Nov 30, 2018

Hi @SeekerWing we're tracking the work for clientside metrics here: #23

@SeekerWing
Copy link

@dagnir thanks; apologies for duplication

@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
@millems
Copy link
Contributor

millems commented Jul 8, 2019

Closing in favor of #35 and #23

@millems millems closed this as completed Jul 8, 2019
aws-sdk-java-automation added a commit that referenced this issue Dec 16, 2019
…ea3e1556

Pull request: release <- staging/b890cf7c-48ab-4ce2-a084-b95fea3e1556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 New feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

5 participants