Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Select Object Content #859

Closed
millems opened this issue Nov 20, 2018 · 17 comments · Fixed by #2943
Closed

S3 Select Object Content #859

millems opened this issue Nov 20, 2018 · 17 comments · Fixed by #2943
Labels
1.x Parity feature-request A feature should be added or improved.

Comments

@millems
Copy link
Contributor

millems commented Nov 20, 2018

The S3 SelectObjectContent isn't yet supported in V2, so customers have to use 1.11.x. This API should be supported in V2.

@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
@humanzz
Copy link

humanzz commented Jun 12, 2019

Any updates on this?

@millems millems changed the title Support S3's SelectObjectContent S3 Select Object Content Jul 8, 2019
@abatkin
Copy link

abatkin commented Feb 19, 2020

Any reason why the release notes claim that 2.10.3 (2019-10-28) contains support for SelectObjectContent?

@abatkin
Copy link

abatkin commented Feb 19, 2020

Also, should this get the 1.11.x Parity tag?

@spfink
Copy link
Contributor

spfink commented Feb 19, 2020

@abatkin added 1.11.x Parity tag.

The changelog includes that note on SelectObjectContent as there was an upstream release of an S3 update for AWS. That update only pertained to S3 Select and while we don't support S3 Select we don't filter S3 releases at that granular of a level. It was likely either a no-op for us or potentially added new documentation to other methods.

@abbas-v1
Copy link

Til now S3 Select is only available in v1?

@ilio
Copy link

ilio commented Nov 4, 2020

Hi AWS team, please add the feature support.

@cemo
Copy link

cemo commented May 3, 2021

Can we contribute to support this as well?

@ilio
Copy link

ilio commented May 4, 2021

I have implemented the functionality, but it is in a quick and dirty format, if you want I can later cleanup and share my code.

@amannm
Copy link

amannm commented May 29, 2021

This has been open for a while. Is this portion of the S3 API being omitted from 2.x support on purpose? Otherwise I guess I can see the difficulty with implementing this, after looking at the code. This use of S3 doesn't fit in with the "Wrong Abstraction" that's currently coded over the simpler S3 APIs in v2. This will require a significant refactoring to enable support. Unfortunate. Hope it gets done one day.

@millems
Copy link
Contributor Author

millems commented Jun 1, 2021

It's not being omitted on purpose, except for prioritization purposes. It's still in our backlog.

@raghuvaran
Copy link

raghuvaran commented Jun 17, 2021

Any ETA?

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dagnir
Copy link
Contributor

dagnir commented Jan 5, 2022

Hi all, I'm happy to report that this PR #2943 adds support for this operation, and has now been merged. It will be part of the next release of the SDK.

@NoelCov
Copy link

NoelCov commented Feb 13, 2024

Has this been released? I seen the last comment from Jan 4 2022 says the PR has been merged and that it will be part of the next release of the SDK but I'm using SDK V2 and don't seem to have access to this yet.

@kekbur
Copy link

kekbur commented Feb 13, 2024

Has this been released?

It has been released. Check the version of your SDK, it should contain at least the class SelectObjectContentRequest.

@NoelCov
Copy link

NoelCov commented Feb 14, 2024

Has this been released?

It has been released. Check the version of your SDK, it should contain at least the class SelectObjectContentRequest.

Hey there @kekbur, thanks for the reply. I did see that for the Java AWS SDK V2 the SelectObjectContentRequest and SelectObjectContentResponse exist and are available, however I did not find a way to make the actual call to select the object content. I looked for a while and didn't find a way to do it. At the end I ended up just switching to the SDK V1 for now. However, if you know of a way to do it using the Java SDK V2 I'd appreciate if you can link a resource or something like that here so I can look at it, thanks a lot.

@kekbur
Copy link

kekbur commented Feb 14, 2024

@NoelCov, I think it's only possible with the S3AsyncClient class and not S3Client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Parity feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.