Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor xml response handler to handle SdkPojo #2854

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Nov 18, 2021

Context

This is needed to support event streaming for services using xml protocol. #859

Description

  • Refactored xml response handler to handle SdkPojo (event stream type)
  • The structure of the related xml classes now matches with the one of the json classes.
    • AwsXmlResponseHandler & AwsJsonResponseHandler: delegates to the underlying response handler and adds response metadata
    • XmlResponseHandler & JsonResponseHandler: AwsResponse ignorant, unmarshalls the response.

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner November 18, 2021 02:08
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

94.4% 94.4% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit 64a0a67 into master Nov 18, 2021
@zoewangg zoewangg deleted the zoewang/s3SelectPart1 branch November 18, 2021 22:17
aws-sdk-java-automation added a commit that referenced this pull request Jan 8, 2024
…97f224380

Pull request: release <- staging/47697a81-34bb-4e6b-ae81-65197f224380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants