test: fix type checks in e2e tests (#6075)

aws · May 8, 2024 · 3179af2 · 3179af2
1 parent 74e4c14
commit 3179af2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/packages/ec2-metadata-service/src/MetadataService.e2e.spec.ts b/packages/ec2-metadata-service/src/MetadataService.e2e.spec.ts
@@ -3,9 +3,9 @@ import { fromInstanceMetadata } from "@aws-sdk/credential-providers";
 import { MetadataService } from "./MetadataService";
 
 describe("MetadataService E2E Tests", () => {
-  let metadataService;
+  let metadataService: any;
   const provider = fromInstanceMetadata({ timeout: 1000, maxRetries: 0 });
-  let metadataServiceAvailable;
+  let metadataServiceAvailable: any;
 
   beforeAll(async () => {
     try {
@@ -35,7 +35,7 @@ describe("MetadataService E2E Tests", () => {
     if (!metadataServiceAvailable) {
       return;
     }
-    const metadata = await metadataService.request("/latest/meta-data/", {});
+    const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
     expect(metadata).toBeDefined();
     expect(typeof metadata).toBe("string");
     const lines = metadata.split("\n").map((line) => line.trim());
@@ -49,7 +49,7 @@ describe("MetadataService E2E Tests", () => {
       return;
     }
     metadataService.disableFetchToken = true; // make request without token
-    const metadata = await metadataService.request("/latest/meta-data/", {});
+    const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
     expect(metadata).toBeDefined();
     expect(typeof metadata).toBe("string");
     expect(metadata.length).toBeGreaterThan(0);
@@ -67,7 +67,7 @@ describe("MetadataService E2E Tests", () => {
       throw { name: "TimeoutError" }; // Simulating TimeoutError
     });
     // Attempt to fetch metadata, expecting IMDSv1 fallback (request without token)
-    const metadata = await metadataService.request("/latest/meta-data/", {});
+    const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
     expect(metadata).toBeDefined();
     expect(typeof metadata).toBe("string");
     const lines = metadata.split("\n").map((line) => line.trim());
@@ -85,7 +85,7 @@ describe("MetadataService E2E Tests", () => {
       jest.spyOn(metadataService, "fetchMetadataToken").mockImplementationOnce(async () => {
         throw { statusCode: errorCode };
       });
-      const metadata = await metadataService.request("/latest/meta-data/", {});
+      const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
       expect(metadata).toBeDefined();
       expect(typeof metadata).toBe("string");
       const lines = metadata.split("\n").map((line) => line.trim());

diff --git a/packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.e2e.spec.ts b/packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.e2e.spec.ts
@@ -239,7 +239,9 @@ async function createClientAndRecorder() {
       const commandName = context.commandName + s3ExpressSuffix;
       const input = args.input;
       const commandRecorder = (recorder.calls[commandName] = recorder.calls[commandName] ?? {});
+      // @ts-expect-error Element implicitly has an 'any' type
       commandRecorder[input["Bucket"] ?? "-"] |= 0;
+      // @ts-expect-error Element implicitly has an 'any' type
       commandRecorder[input["Bucket"] ?? "-"]++;
 
       return continuation;

diff --git a/packages/s3-presigned-post/src/createPresignedPost.e2e.spec.ts b/packages/s3-presigned-post/src/createPresignedPost.e2e.spec.ts
@@ -82,7 +82,7 @@ describe(createPresignedPost.name, () => {
       expect(precheck).toBeInstanceOf(NoSuchKey);
 
       const submit: { statusCode: number } = await new Promise((resolve, reject) => {
-        form.submit(url, (err, res) => {
+        form.submit(url, (err: any, res: any) => {
           if (err) reject(err);
           resolve(res);
         });