Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-s3,aws-models): change CompleteMultipartUpload to match doc #2434

Closed
wants to merge 1 commit into from

Conversation

paulreece42
Copy link

See issue #1814 , I just did a search and replace so everything is consistent:

$ find . -exec sed s/CompletedMultipartUpload/CompleteMultipartUpload/g {} \;

Issue

#1814

Description

Correctness fix as most everything uses "CompleteMultipartUpload" instead of "CompletedMultipartUpload" which does not match the docs (longer discussion in #1814 )

Testing

Ran a node script to do a multipart upload, and it worked. Full test suite was not run.

Additional context

None


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

See issue aws#1814 , I just did a search and replace so everything is consistent:

    $ find . -exec sed s/CompletedMultipartUpload/CompleteMultipartUpload/g {} \;
@youbek
Copy link

youbek commented Jun 22, 2021

Hi Guys!

We are using the Upload method from the lib-storage package, and it's also throwing the same MalformedACLError. Because under the hood, upload method from lib-storage uses CompleteMultipartUploadCommand

@youbek
Copy link

youbek commented Jun 23, 2021

@alexforsyth @AllanZhengYP @trivikr Any updates on this? Thank you in advance!

@ajredniwja ajredniwja requested review from alexforsyth, AllanZhengYP and trivikr and removed request for AllanZhengYP, alexforsyth and trivikr July 21, 2021 15:43
@ignlg
Copy link

ignlg commented Jul 29, 2021

This bug is still blocking midsize and large uploads to S3, core functionality for us. Any estimation?

@brettstack
Copy link

@alexforsyth @trivikr can we please merge this? It's a typo that's causing a bug for anyone wanting to multipart upload files.

@AllanZhengYP
Copy link
Contributor

Hi @paulreece42 @ignlg @brettstack

Anything in clients folder is generated, so this fix will be overwritten in the next release. This issue should be fixed by the client generator. I will create a separate fix for it as I mentioned in #1814 (comment). Close it for now.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants