-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix importing node-only modules in browser env #2491
Conversation
There are more incorrect runtimeConfig configs in the clients packages, but I fixed only the few that was blocking me of using cognito sdk |
…s browser runtime
This is definitely the problem...
Hopefully the sdk team jumps on this in the nearish future! Originally posted by @dancingfrog in aws-amplify/amplify-js#9639 (comment) |
@trivikr , can you review? |
The issue in #2478 was resolved after detailed discussions. The TODO here is to create a new specific bug report, if the issue continue exists. If it doesn't, close the PR. |
Hello everyone on the thread. Thank you again for your contribution. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
#2478
Description
Fix not being able to import
@aws-sdk/credential-provider-cognito-identity
and@aws-sdk/client-cognito-identity
invite-project
Testing
Additional context
I've detected that
package.json
browser runtimeConfig entry in@aws-sdk/client-cognito-identity
was pointing to the typescript source file, but the built file was missing, so I fixed it.Also, I moved node-only code of
@aws-sdk/credential-provider-web-identity
into@aws-sdk/credential-provider-node-identity
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.