Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): extend TypeScript config from @tsconfig/node16 #6037

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 30, 2024

Issue

Internal JS-5174

End of support for Node.js 14.x #6034

Description

Extend TypeScript config from @tsconfig/node16

Testing

Verified using aws-samples/aws-sdk-js-tests

# in aws-sdk-js-v3
$ client-cognito-identity> npm pack
...
aws-sdk-client-cognito-identity-3.565.0.tgz

$ client-dynamodb> npm pack
...
aws-sdk-client-dynamodb-3.565.0.tgz

$ credential-provider-cognito-identity> npm pack
...
aws-sdk-credential-provider-cognito-identity-3.565.0.tgz
# in aws-sdk-js-tests
$ utils> yarn add ~/workspace/aws-sdk-js-v3/clients/client-cognito-identity/aws-sdk-client-cognito-identity-3.565.0.tgz

$ utils> yarn add ~/workspace/aws-sdk-js-v3/clients/client-dynamodb/aws-sdk-client-dynamodb-3.565.0.tgz

$ utils> yarn add ~/workspace/aws-sdk-js-v3/packages/credential-provider-cognito-identity/aws-sdk-credential-provider-cognito-identity-3.565.0.tgz

# Update packages/utils/src/config.js
$ aws-sdk-js-tests> yarn start:node
# successful listTables call from DynamoDB printed on console

$ aws-sdk-js-tests> yarn start:web
# successful listTables call from DynamoDB shown in browser

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner April 30, 2024 15:54
@trivikr trivikr marked this pull request as draft April 30, 2024 15:55
@trivikr trivikr changed the title chore(scripts): extend TypeScript config from @tsconfig/node16 chore: extend TypeScript config from @tsconfig/node16 Apr 30, 2024
@trivikr trivikr force-pushed the use-tsconfig-node16-clients branch from a67285d to 428c8ce Compare April 30, 2024 17:42
@trivikr trivikr changed the title chore: extend TypeScript config from @tsconfig/node16 chore(clients): extend TypeScript config from @tsconfig/node16 Apr 30, 2024
@trivikr trivikr force-pushed the use-tsconfig-node16-clients branch from 428c8ce to 62d5a77 Compare April 30, 2024 20:48
@trivikr trivikr marked this pull request as ready for review April 30, 2024 20:48
@trivikr trivikr merged commit c4fb66d into aws:main Apr 30, 2024
5 checks passed
@trivikr trivikr deleted the use-tsconfig-node16-clients branch April 30, 2024 22:03
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants