Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/httpAuthSchemes): set configuration sources for sigv4a signingRegionSet #6368

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Aug 7, 2024

Issue

JS-4976

Description

This adds a config resolver for sigv4a and its config field "sigv4aSigningRegionSet" which is an optional list of AWS regions.

usage:

  const s3 = new S3({
    region: "us-west-2",
    sigv4aSigningRegionSet: ["us-west-2", "us-east-1"],
  });

This is quite optional at this point, because endpoint resolution for Amazon S3 always returns a signingRegionSet of * if resolving the auth scheme to sigv4a. This will support future developments in multi-auth and expanded usage of sigv4a.

Testing

  • ci
  • e2e
  • e2e:legacy

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner August 7, 2024 18:09
@kuhe kuhe force-pushed the feat/auth branch 3 times, most recently from 5dbf48b to 3967668 Compare August 9, 2024 14:34
@kuhe kuhe merged commit 03bb39f into aws:main Aug 9, 2024
5 checks passed
@kuhe kuhe deleted the feat/auth branch August 9, 2024 20:54
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants