fix: add global hostnames for additional regions (#4675)

* fix: add global hostnames for additional regions * fix: additional test cases for route53 partition endpoints
aws · Sep 5, 2024 · a660142 · a660142
1 parent 09b57a6
commit a660142
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/lib/region_config_data.json b/lib/region_config_data.json
@@ -36,6 +36,8 @@
       "globalEndpoint": true,
       "signingRegion": "us-isob-east-1"
     },
+    "us-isof-*/route53": "globalUsIsof",
+    "eu-isoe-*/route53": "globalEuIsoe",
 
     "*/waf": "globalSSL",
 
@@ -241,6 +243,16 @@
       "globalEndpoint": true,
       "signingRegion": "us-gov-west-1"
     },
+    "globalUsIsof": {
+      "endpoint": "{service}.csp.hci.ic.gov",
+      "globalEndpoint": true,
+      "signingRegion": "us-isof-south-1"
+    },
+    "globalEuIsoe": {
+      "endpoint": "{service}.cloud.adc-e.uk",
+      "globalEndpoint": true,
+      "signingRegion": "eu-isoe-west-1"
+    },
     "s3signature": {
       "endpoint": "{service}.{region}.amazonaws.com",
       "signatureVersion": "s3"

diff --git a/test/region_config.spec.js b/test/region_config.spec.js
@@ -18,6 +18,25 @@ describe('region_config.js', function() {
     });
   });
 
+  [AWS.Route53].forEach(function(svcClass) {
+    [
+      'us-isof-south-1',
+      'eu-isoe-west-1',
+      'us-gov-west-1',
+      'cn-northwest-1',
+      'cn-north-1'
+    ].forEach(function(region) {
+      it('uses a global partition endpoint for ' + svcClass.serviceIdentifier, function() {
+        var service = new svcClass({
+          region: region
+        });
+        expect(service.endpoint.host).to.contain(service.serviceIdentifier + '.');
+        expect(service.endpoint.host).not.to.contain(region);
+        expect(service.isGlobalEndpoint).to.equal(true);
+      });
+    });
+  });
+
   it('always enables SSL for Route53', function() {
     var service = new AWS.Route53;
     expect(service.config.sslEnabled).to.equal(true);