Retry on RDSDataService Communications link failure #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@ajredniwja is there anyone I should ping for a review? |
|
@AllanFly120 will review this soon. |
|
🚀 ? |
|
@ajredniwja can you or some other contributor review and merge this? We're also looking at using Data API and this issue definitely lowers the developer experience. |
AllanZhengYP
approved these changes
Jan 9, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2914
Running AWS.RDSDataService.executeStatement against an auto-paused Serverless Aurora in a paused state results in
400 - BadRequestException: Communications link failure.I have limited making retryable to the following conditions:
400BadRequestExceptionCommunications link failureI included the error message condition because the service documentation is not clear that "BadRequestException" is limited to this condition.
Checklist
npm run testpasses.d.tsfile is updatednpm run add-changebundle exec rake docs:apiand inspectdoc/latest/index.htmlif documentation is changedrunnpm run integrationif integration test is changednon-code related change (markdown/git settings etc)