Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exceptions thrown when making DynamoDB queries using object-mapper programming model with DisableFetchingTableMetadata and missing index definitions #3058

Merged

Conversation

ashovlin
Copy link
Member

Description

Motivation and Context

DOTNET-7182 - we want to avoid any null reference or index out of range exceptions when accessing the SDK's internal cache of table metadata

Testing

  • Added new tests assert our expected exception type for a few cases
  • Existing net35/net45 DDB unit and integration tests pass locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed - still need to do an internal dry-run

License

  • I confirm that this pull request can be released under the Apache 2 license

…apper programming model with DisableFetchingTableMetadata and missing index definitions
@ashovlin ashovlin merged commit 014f49d into feature/ddb-skip-describe-table Sep 26, 2023
@ashovlin ashovlin deleted the shovlia/ddb-missingkey-exceptions branch September 26, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants