Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Aws\Sns\MessageValidator\MessageValidator classes #625

Closed
pako-pl opened this issue Jun 14, 2015 · 14 comments
Closed

Missing Aws\Sns\MessageValidator\MessageValidator classes #625

pako-pl opened this issue Jun 14, 2015 · 14 comments
Labels
guidance Question that needs advice or information.

Comments

@pako-pl
Copy link

pako-pl commented Jun 14, 2015

The SNS MessageValidator classes did not get included in version 3 of AWS PHP SDK. So after upgrading to v3 there is no way to validate incoming SNS messages. Do you offer any alternative? The migration guide does not mention this issue at all, we discovered the problem during migration.

@jeremeamia
Copy link
Contributor

We actually did mention it in the migration guide in this section. We plan on releasing it as a separate package, since it is useful on its own and doesn't really need to depend on the SDK. I'll try to get that repo published soon (this week?), and I'll make sure to ping this isue.

@jeremeamia jeremeamia added guidance Question that needs advice or information. v3 labels Jun 15, 2015
@pako-pl
Copy link
Author

pako-pl commented Jun 16, 2015

Sorry, I missed the note about SNS Message Validator (probably because the specific class name wasn't mentioned there). Great to hear that the package will be released soon.

@StevenBullen
Copy link

@jeremeamia
Any update on this? :)

@jeremeamia
Copy link
Contributor

Yeah, we've extracted it out and completed the code, and it is now under internal review.

@StevenBullen
Copy link

Thanks

@jeremeamia jeremeamia self-assigned this Jun 26, 2015
@jeremeamia
Copy link
Contributor

The repository is here: https://github.com/aws/aws-php-sns-message-validator. We are still working on it before we release a stable version. Not much is changing though from what there was in the V2 SDK. I'm going to close this issue. Feel free to take the new package for a test drive if you want to help out, and open any issues on that repo that you might encounter. Thanks.

@StevenBullen
Copy link

Great news and will do. Thanks again.

@atkinsonm
Copy link

Glad I stumbled upon this post. I had been scouring the Internet trying to find out why I couldn't load AWS\Sns\Message for close to 2 hours. If it is no longer included in the SDK AWS really needs to update the documentation.

@jeremeamia
Copy link
Contributor

Sorry that tripped you up. Where in the documentation would that have been the most useful to you?

@atkinsonm
Copy link

@jeremeamia right about here: http://docs.aws.amazon.com/aws-sdk-php/v3/api/namespace-Aws.Sns.html. I found it a little misleading as if it was still part of the SDK

@jeremeamia
Copy link
Contributor

Yeah, I could see how you would find that misleading. I was also thinking some modifications here and here might be helpful too. I no longer work on the SDK, but I'm sure @jeskew could make something good happen.

@atkinsonm
Copy link

Absolutely. I'm up and running by using the aws/aws-php-sns-message-validator repo. I appreciate the help!

@jeskew
Copy link
Contributor

jeskew commented Dec 31, 2015

@melusom The validator classes included in the phar and zip distributions, which are what we use to generate the API docs. PSR-7 interfaces and Guzzle classes are documented as well, though it is more clear in those cases that the code isn't part of the SDK.

Would it have helped if the aws/aws-php-sns-message-validator were suggested by composer?

@jeskew jeskew reopened this Dec 31, 2015
@atkinsonm
Copy link

@jeskew Ah I see. I did the composer install. Yeah, the suggestion would've helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

5 participants