-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Aws\Sns\MessageValidator\MessageValidator classes #625
Comments
We actually did mention it in the migration guide in this section. We plan on releasing it as a separate package, since it is useful on its own and doesn't really need to depend on the SDK. I'll try to get that repo published soon (this week?), and I'll make sure to ping this isue. |
Sorry, I missed the note about SNS Message Validator (probably because the specific class name wasn't mentioned there). Great to hear that the package will be released soon. |
@jeremeamia |
Yeah, we've extracted it out and completed the code, and it is now under internal review. |
Thanks |
The repository is here: https://github.com/aws/aws-php-sns-message-validator. We are still working on it before we release a stable version. Not much is changing though from what there was in the V2 SDK. I'm going to close this issue. Feel free to take the new package for a test drive if you want to help out, and open any issues on that repo that you might encounter. Thanks. |
Great news and will do. Thanks again. |
Glad I stumbled upon this post. I had been scouring the Internet trying to find out why I couldn't load AWS\Sns\Message for close to 2 hours. If it is no longer included in the SDK AWS really needs to update the documentation. |
Sorry that tripped you up. Where in the documentation would that have been the most useful to you? |
@jeremeamia right about here: http://docs.aws.amazon.com/aws-sdk-php/v3/api/namespace-Aws.Sns.html. I found it a little misleading as if it was still part of the SDK |
Absolutely. I'm up and running by using the aws/aws-php-sns-message-validator repo. I appreciate the help! |
@melusom The validator classes included in the phar and zip distributions, which are what we use to generate the API docs. PSR-7 interfaces and Guzzle classes are documented as well, though it is more clear in those cases that the code isn't part of the SDK. Would it have helped if the aws/aws-php-sns-message-validator were suggested by composer? |
@jeskew Ah I see. I did the composer install. Yeah, the suggestion would've helped. |
Better document the SNS validator package. Resolves #625
The SNS MessageValidator classes did not get included in version 3 of AWS PHP SDK. So after upgrading to v3 there is no way to validate incoming SNS messages. Do you offer any alternative? The migration guide does not mention this issue at all, we discovered the problem during migration.
The text was updated successfully, but these errors were encountered: