enhancement: flexible checksums #2999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stobrien89
force-pushed
the
checksums-v2
branch
3 times, most recently
from
3d43db0
to
22fb848
Compare
stobrien89
force-pushed
the
checksums-v2
branch
2 times, most recently
from
16cb321
to
c1b77ce
Compare
yenfryherrerafeliz
requested changes
Oct 8, 2024
stobrien89
force-pushed
the
checksums-v2
branch
from
c1b77ce
to
0762584
Compare
yenfryherrerafeliz
requested changes
Oct 9, 2024
stobrien89
force-pushed
the
checksums-v2
branch
2 times, most recently
from
a507de5
to
dce99fd
Compare
yenfryherrerafeliz
requested changes
Oct 11, 2024
stobrien89
force-pushed
the
checksums-v2
branch
from
dce99fd
to
ccae080
Compare
stobrien89
requested review from
yenfryherrerafeliz
and removed request for
yenfryherrerafeliz
yenfryherrerafeliz
approved these changes
Oct 16, 2024
stobrien89
force-pushed
the
checksums-v2
branch
from
957bcfa
to
fef1fad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds default checksum calculation, deprecates the
AddContentMD5config option as S3 plans to deprecate MD5 checksums soon, adds two S3 client config options:request_checksum_calculationandresponse_checksum_validationwith acceptable values for both being eitherwhen_supportedorwhen_required.request_checksum_calculationwill default towhen_supported, which means if an operation supports checksum calculation (indicated via modeling), the SDK will calculate the checksum and add the appropriate header. If it is set towhen_required, the SDK will only compute and send a checksum when the operation requires anhttpRequestChecksum.response_checksum_validationalso defaults towhen_supported, which means if an operation models response algorithms, an attempt to validate a response checksum will be made.when_requiredwill only validate response checksums when response checksum are modeled ANDChecksumModeis set toenabledon the command.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.