Add support for dynamic timeout and heartbeat in Task state #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
wong-a
requested changes
Jan 15, 2021
src/stepfunctions/steps/service.py
Outdated
| @@ -107,7 +107,9 @@ def __init__(self, state_id, wait_for_callback=False, **kwargs): | |||
| state_id (str): State name whose length **must be** less than or equal to 128 unicode characters. State names **must be** unique within the scope of the whole state machine. | |||
| wait_for_callback(bool, optional): Boolean value set to `True` if the Task state should wait for callback to resume the operation. (default: False) | |||
| timeout_seconds (int, optional): Positive integer specifying timeout for the state in seconds. If the state runs longer than the specified timeout, then the interpreter fails the state with a `States.Timeout` Error Name. (default: 60) | |||
| timeout_seconds_path (str, optional): Path applied to the state's input to select the integer to be used for timeout seconds duration. | |||
There was a problem hiding this comment.
Aren't these applicable to all Task types and not just the ones you've updated?
lialln
force-pushed
the
dynamic-timeout
branch
from
7359227
to
7c397ca
Compare
Co-authored-by: Adam Wong <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
wong-a
requested changes
Jan 16, 2021
src/stepfunctions/steps/states.py
Outdated
| @@ -583,14 +583,21 @@ def __init__(self, state_id, **kwargs): | |||
| state_id (str): State name whose length **must be** less than or equal to 128 unicode characters. State names **must be** unique within the scope of the whole state machine. | |||
| resource (str): A URI that uniquely identifies the specific task to execute. The States language does not constrain the URI scheme nor any other part of the URI. | |||
| timeout_seconds (int, optional): Positive integer specifying timeout for the state in seconds. If the state runs longer than the specified timeout, then the interpreter fails the state with a `States.Timeout` Error Name. (default: 60) | |||
| timeout_seconds_path (str, optional): Path applied to the state's input to select the integer to be used for timeout seconds duration. | |||
There was a problem hiding this comment.
Grammar and extra help taken from the docs:
Suggested change
| timeout_seconds_path (str, optional): Path applied to the state's input to select the integer to be used for timeout seconds duration. | |
| timeout_seconds_path (str, optional): Path specifying the state's timeout value in seconds from the state input. When resolved, the path must select a field whose value is a positive integer. |
Same suggestion applies for heartbeat_seconds_path
wong-a
approved these changes
Jan 16, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
yoodan93
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.